Re: [Qemu-devel] [PATCH] Deprecate Python 2 support

[Eduardo Habkost]

On Mon, May 06, 2019 at 04:12:02PM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
> 
> > Python 2 will reach end of life in January 1 2020.  Declare it as
> > deprecated.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  configure            | 8 ++++++++
> >  qemu-deprecated.texi | 8 ++++++++
> >  2 files changed, 16 insertions(+)
> >
> > diff --git a/configure b/configure
> > index 5b183c2e39..50385061ed 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6461,6 +6461,14 @@ if test "$supported_os" = "no"; then
> >      echo "us upstream at address@hidden"
> >  fi
> >  
> > +# Note that if the Python conditional here evaluates True we will exit
> > +# with status 1 which is a shell 'false' value.
> > +if ! $python -c 'import sys; sys.exit(sys.version_info < (3,0))'; then
> > +  echo
> > +  echo "WARNING: Python 2 support is deprecated" >&2
> > +  echo "WARNING: Python 3 will be required for building future versions of 
> > QEMU" >&2
> 
> Please don't shout "warning".  
>
[...]
> 
> Reviewed-by: Markus Armbruster <address@hidden>

Thanks!  Queued after changing messages to "warning: ..."

-- 
Eduardo