Re: [Qemu-devel] [PATCH 22/26] target/unicore32: Convert to CPUClass::tlb_fill

[Guan Xuetao]

It's OK for unicore32 codes.

Thanks.

Guan Xuetao


> -----Original Messages-----
> From: "Peter Maydell" <address@hidden>
> Sent Time: 2019-04-30 18:06:03 (Tuesday)
> To: "Richard Henderson" <address@hidden>
> Cc: "QEMU Developers" <address@hidden>, "Guan Xuetao" <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH 22/26] target/unicore32: Convert to 
> CPUClass::tlb_fill
> 
> On Wed, 3 Apr 2019 at 04:58, Richard Henderson
> <address@hidden> wrote:
> >
> > Cc: Guan Xuetao <address@hidden>
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> >  target/unicore32/cpu.h       |  5 +++--
> >  target/unicore32/cpu.c       |  5 +----
> >  target/unicore32/helper.c    | 23 -----------------------
> >  target/unicore32/op_helper.c | 14 --------------
> >  target/unicore32/softmmu.c   | 19 +++++++++++++++----
> >  5 files changed, 19 insertions(+), 47 deletions(-)
> 
> Reviewed-by: Peter Maydell <address@hidden>
> 
> You might note in the commit message that we can just delete
> the user-mode (non-)handling of tlb fill because we
> don't support unicore32 linux-user any more.
> 
> thanks
> -- PMM