[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl |
Date: |
Wed, 8 May 2019 21:54:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 04.05.19 07:52, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/cris/translate.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index b005a5c20e..31b40a57f9 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -1686,18 +1686,11 @@ static int dec_cmp_r(CPUCRISState *env, DisasContext
> *dc)
>
> static int dec_abs_r(CPUCRISState *env, DisasContext *dc)
> {
> - TCGv t0;
> -
> LOG_DIS("abs $r%u, $r%u\n",
> dc->op1, dc->op2);
> cris_cc_mask(dc, CC_MASK_NZ);
>
> - t0 = tcg_temp_new();
> - tcg_gen_sari_tl(t0, cpu_R[dc->op1], 31);
> - tcg_gen_xor_tl(cpu_R[dc->op2], cpu_R[dc->op1], t0);
> - tcg_gen_sub_tl(cpu_R[dc->op2], cpu_R[dc->op2], t0);
> - tcg_temp_free(t0);
> -
> + tcg_gen_abs_tl(cpu_R[dc->op2], cpu_R[dc->op1]);
> cris_alu(dc, CC_OP_MOVE,
> cpu_R[dc->op2], cpu_R[dc->op2], cpu_R[dc->op2], 4);
> return 2;
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v3 14/31] tcg: Add INDEX_op_dupm_vec, (continued)
- [Qemu-devel] [PATCH v3 14/31] tcg: Add INDEX_op_dupm_vec, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 15/31] tcg: Add gvec expanders for variable shift, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 19/31] tcg/i386: Support vector scalar shift opcodes, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 18/31] tcg: Add gvec expanders for vector shift by scalar, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 20/31] tcg: Add support for integer absolute value, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 21/31] tcg: Add support for vector absolute value, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 22/31] tcg/i386: Support vector absolute value, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 23/31] tcg/aarch64: Support vector absolute value, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 24/31] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl, Richard Henderson, 2019/05/04
- Re: [Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl,
David Hildenbrand <=
- [Qemu-devel] [PATCH v3 26/31] target/ppc: Use tcg_gen_abs_i32, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 27/31] target/ppc: Use tcg_gen_abs_tl, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 28/31] target/s390x: Use tcg_gen_abs_i64, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 31/31] tcg/aarch64: Do not advertise minmax for MO_64, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 30/31] target/xtensa: Use tcg_gen_abs_i32, Richard Henderson, 2019/05/04
- [Qemu-devel] [PATCH v3 29/31] target/tricore: Use tcg_gen_abs_tl, Richard Henderson, 2019/05/04