Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

[Marc-André Lureau]

Hi

On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann <address@hidden> wrote:
>
>   Hi,
>
> > +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = {
> > +    .base_name = TYPE_VHOST_USER_INPUT_PCI,
> > +    .generic_name = "vhost-user-input-pci",
> > +    .transitional_name = "vhost-user-input-pci-transitional",
> > +    .non_transitional_name = "vhost-user-input-pci-non-transitional",
>
> virtio-input is virtio 1.0 only, so we don't need these variants.
> Incremental fix below, if you ack that I can squash it for the pull req.
> Or you send a v3 (in case you have other changes pending).
>
> cheers,
>   Gerd

ack, thanks

>
> --- a/hw/virtio/vhost-user-input-pci.c
> +++ b/hw/virtio/vhost-user-input-pci.c
> @@ -13,7 +13,7 @@
>
>  typedef struct VHostUserInputPCI VHostUserInputPCI;
>
> -#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci-base"
> +#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci"
>
>  #define VHOST_USER_INPUT_PCI(obj) \
>      OBJECT_CHECK(VHostUserInputPCI, (obj), TYPE_VHOST_USER_INPUT_PCI)
> @@ -37,9 +37,7 @@ static void vhost_user_input_pci_instance_init(Object *obj)
>
>  static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = {
>      .base_name = TYPE_VHOST_USER_INPUT_PCI,
> -    .generic_name = "vhost-user-input-pci",
> -    .transitional_name = "vhost-user-input-pci-transitional",
> -    .non_transitional_name = "vhost-user-input-pci-non-transitional",
> +    .generic_name = TYPE_VHOST_USER_INPUT_PCI,
>      .parent = TYPE_VIRTIO_INPUT_PCI,
>      .instance_size = sizeof(VHostUserInputPCI),
>      .instance_init = vhost_user_input_pci_instance_init,