Re: [Qemu-devel] [PATCH 2/2] virtio-input: fix Kconfig dependency and Makefile

[Marc-André Lureau]

On Thu, May 9, 2019 at 11:31 AM Gerd Hoffmann <address@hidden> wrote:
>
> Make VIRTIO_INPUT_HOST depend on VIRTIO_INPUT.
> Use CONFIG_VIRTIO_INPUT_HOST in Makefile.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  hw/input/Kconfig       | 2 +-
>  hw/input/Makefile.objs | 4 +---
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index 50e55e353847..889363d8aef1 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -27,7 +27,7 @@ config VIRTIO_INPUT
>  config VIRTIO_INPUT_HOST
>      bool
>      default y
> -    depends on VIRTIO && LINUX
> +    depends on VIRTIO_INPUT && LINUX
>
>  config VHOST_USER_INPUT
>      bool
> diff --git a/hw/input/Makefile.objs b/hw/input/Makefile.objs
> index 3eddf00f2bba..d1de30770854 100644
> --- a/hw/input/Makefile.objs
> +++ b/hw/input/Makefile.objs
> @@ -9,9 +9,7 @@ common-obj-$(CONFIG_TSC2005) += tsc2005.o
>
>  common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input.o
>  common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-hid.o
> -ifeq ($(CONFIG_LINUX),y)
> -common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-host.o
> -endif
> +common-obj-$(CONFIG_VIRTIO_INPUT_HOST) += virtio-input-host.o
>  common-obj-$(CONFIG_VHOST_USER_INPUT) += vhost-user-input.o
>
>  obj-$(CONFIG_MILKYMIST) += milkymist-softusb.o
> --
> 2.18.1
>
>


-- 
Marc-André Lureau