[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/8] linux-user/sparc: Use WREG constants in spar
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 4/8] linux-user/sparc: Use WREG constants in sparc/target_cpu.h |
Date: |
Thu, 9 May 2019 20:27:06 -0700 |
This fixes a naming bug wherein we used "UREG_FP" to access the
stack pointer. OTOH, the "UREG_FP" constant was also defined
incorrectly such that it *did* reference the stack pointer.
Signed-off-by: Richard Henderson <address@hidden>
---
linux-user/sparc/target_cpu.h | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
index a92748cae3..567351d564 100644
--- a/linux-user/sparc/target_cpu.h
+++ b/linux-user/sparc/target_cpu.h
@@ -42,15 +42,9 @@ static inline void cpu_set_tls(CPUSPARCState *env,
target_ulong newtls)
env->gregs[7] = newtls;
}
-#ifndef UREG_I6
-#define UREG_I6 6
-#endif
-#ifndef UREG_FP
-#define UREG_FP UREG_I6
-#endif
-
static inline abi_ulong get_sp_from_cpustate(CPUSPARCState *state)
{
- return state->regwptr[UREG_FP];
+ return state->regwptr[WREG_SP];
}
+
#endif
--
2.17.1
- [Qemu-devel] [PATCH v2 0/8] linux-user sparc fixes, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 1/8] linux-user: Disallow setting newsp for fork, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 2/8] linux-user: Pass the parent env to cpu_clone_regs, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 4/8] linux-user/sparc: Use WREG constants in sparc/target_cpu.h,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 6/8] linux-user/sparc: Fix cpu_clone_regs, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 5/8] linux-user/sparc: Use WREG constants in sparc/signal.c, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 8/8] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 7/8] linux-user/sparc: Flush register windows before clone, Richard Henderson, 2019/05/09