[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] ramfb enhancement
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] ramfb enhancement |
Date: |
Fri, 10 May 2019 06:59:46 +0200 |
User-agent: |
NeoMutt/20180716 |
On Thu, May 09, 2019 at 03:57:24PM +0800, Hou Qiming wrote:
> Pulled back the `qemu_create_displaysurface_guestmem` function to create
> the display surface so that the guest memory gets properly unmaped.
>
> Signed-off-by: HOU Qiming <address@hidden>
> ---
> hw/display/ramfb.c | 53 ++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 42 insertions(+), 11 deletions(-)
>
> diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
> index 25c8ad7..c27fcc7 100644
> --- a/hw/display/ramfb.c
> +++ b/hw/display/ramfb.c
> @@ -29,13 +29,50 @@ struct QEMU_PACKED RAMFBCfg {
> struct RAMFBState {
> DisplaySurface *ds;
> uint32_t width, height;
> + hwaddr addr, length;
Why do you add these? Seem not to be used anywhere in the patch ...
Also a more descriptive subject line would be good.
cheers,
Gerd
- [Qemu-devel] Patch: Precautionary glBindTexture in surface_gl_update_texture, Hou Qiming, 2019/05/06
- Re: [Qemu-devel] Patch: Precautionary glBindTexture in surface_gl_update_texture, Marcel Apfelbaum, 2019/05/06
- [Qemu-devel] [PATCH] Multiple ramfb enhancements, Hou Qiming, 2019/05/08
- Re: [Qemu-devel] [PATCH] Multiple ramfb enhancements, Gerd Hoffmann, 2019/05/09
- [Qemu-devel] [PATCH 2/3] ramfb enhancement, Hou Qiming, 2019/05/09
- Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement, Marcel Apfelbaum, 2019/05/09
- Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement, Gerd Hoffmann, 2019/05/10
- Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement, Hou Qiming, 2019/05/10
- Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement, Gerd Hoffmann, 2019/05/10
- [Qemu-devel] [PATCH 3/3] ramfb enhancement, Hou Qiming, 2019/05/09
- Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement, Marcel Apfelbaum, 2019/05/09
- Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement, Hou Qiming, 2019/05/09
- Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement, Marcel Apfelbaum, 2019/05/10
- Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement, Gerd Hoffmann, 2019/05/10