Re: [Qemu-devel] [PULL 00/27] tcg: Add CPUClass::tlb_fill

[Peter Maydell]

On Fri, 10 May 2019 at 16:19, Richard Henderson
<address@hidden> wrote:
>
> The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' 
> into staging (2019-05-10 14:49:36 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-tcg-20190510
>
> for you to fetch changes up to 5f32c102ec3a0db4773d0f74b398191b578c0720:
>
>   tcg: Use tlb_fill probe from tlb_vaddr_to_host (2019-05-10 07:58:11 -0700)
>
> ----------------------------------------------------------------
> Add CPUClass::tlb_fill.
> Improve tlb_vaddr_to_host for use by ARM SVE no-fault loads.
>
> ----------------------------------------------------------------

Compile failure for aarch32 and 32-bit Windows builds:

/home/peter.maydell/qemu/accel/tcg/cputlb.c: In function 'tlb_vaddr_to_host':
/home/peter.maydell/qemu/accel/tcg/cputlb.c:1161:12: error: cast to
pointer from integer of different size
[-Werror=int-to-pointer-cast]
     return (void *)(addr + entry->addend);
            ^

I also saw this link error in my --disable-tcg build:

  LINK    x86_64-softmmu/qemu-system-x86_64
target/i386/cpu.o: In function `x86_cpu_common_class_init':
/home/petmay01/linaro/qemu-for-merges/target/i386/cpu.c:5918:
undefined reference to `x86_cpu_tlb_fill'
collect2: error: ld returned 1 exit status

thanks
-- PMM