[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag
From: |
Pankaj Gupta |
Subject: |
Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag |
Date: |
Mon, 13 May 2019 13:32:28 -0400 (EDT) |
Hi Dan,
While testing device mapper with DAX, I faced a bug with the commit:
commit ad428cdb525a97d15c0349fdc80f3d58befb50df
Author: Dan Williams <address@hidden>
Date: Wed Feb 20 21:12:50 2019 -0800
When I reverted the condition to old code[1] it worked for me. I
am thinking when we map two different devices (e.g with device mapper), will
start & end pfn still point to same pgmap? Or there is something else which
I am missing here.
Note: I tested only EXT4.
[1]
- if (pgmap && pgmap->type == MEMORY_DEVICE_FS_DAX)
+ end_pgmap = get_dev_pagemap(pfn_t_to_pfn(end_pfn), NULL);
+ if (pgmap && pgmap == end_pgmap && pgmap->type ==
MEMORY_DEVICE_FS_DAX
+ && pfn_t_to_page(pfn)->pgmap == pgmap
+ && pfn_t_to_page(end_pfn)->pgmap == pgmap
+ && pfn_t_to_pfn(pfn) == PHYS_PFN(__pa(kaddr))
+ && pfn_t_to_pfn(end_pfn) ==
PHYS_PFN(__pa(end_kaddr)))
dax_enabled = true;
put_dev_pagemap(pgmap);
Thanks,
Pankaj
- [Qemu-devel] [PATCH v8 0/6] virtio pmem driver, Pankaj Gupta, 2019/05/10
- [Qemu-devel] [PATCH v8 1/6] libnvdimm: nd_region flush callback support, Pankaj Gupta, 2019/05/10
- [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver, Pankaj Gupta, 2019/05/10
- [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag,
Pankaj Gupta <=
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/13
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/14
[Qemu-devel] [PATCH v8 4/6] dax: check synchronous mapping is supported, Pankaj Gupta, 2019/05/10
[Qemu-devel] [PATCH v8 5/6] ext4: disable map_sync for async flush, Pankaj Gupta, 2019/05/10
[Qemu-devel] [PATCH v8 6/6] xfs: disable map_sync for async flush, Pankaj Gupta, 2019/05/10
Re: [Qemu-devel] [PATCH v8 0/6] virtio pmem driver, Michael S. Tsirkin, 2019/05/10
Re: [Qemu-devel] [PATCH v8 0/6] virtio pmem driver, Dan Williams, 2019/05/10