[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0 |
Date: |
Tue, 14 May 2019 15:15:39 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Wei Yang (address@hidden) wrote:
> We can eliminate to pass 0.
>
> Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 35bd6213e9..9948b2d021 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1643,10 +1643,10 @@ static inline bool
> migration_bitmap_clear_dirty(RAMState *rs,
> }
>
> static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb,
> - ram_addr_t start, ram_addr_t length)
> + ram_addr_t length)
> {
> rs->migration_dirty_pages +=
> - cpu_physical_memory_sync_dirty_bitmap(rb, start, length,
> + cpu_physical_memory_sync_dirty_bitmap(rb, 0, length,
> &rs->num_dirty_pages_period);
> }
>
> @@ -1735,7 +1735,7 @@ static void migration_bitmap_sync(RAMState *rs)
> qemu_mutex_lock(&rs->bitmap_mutex);
> rcu_read_lock();
> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
> - migration_bitmap_sync_range(rs, block, 0, block->used_length);
> + migration_bitmap_sync_range(rs, block, block->used_length);
> }
> ram_counters.remaining = ram_bytes_remaining();
> rcu_read_unlock();
> @@ -4156,7 +4156,7 @@ static void colo_flush_ram_cache(void)
> memory_global_dirty_log_sync();
> rcu_read_lock();
> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
> - migration_bitmap_sync_range(ram_state, block, 0, block->used_length);
> + migration_bitmap_sync_range(ram_state, block, block->used_length);
> }
> rcu_read_unlock();
>
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0,
Dr. David Alan Gilbert <=