[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] migration/savevm: remove duplicate check of
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] migration/savevm: remove duplicate check of migration_is_blocked |
Date: |
Tue, 14 May 2019 16:55:50 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Wei Yang (address@hidden) wrote:
> Current call flow of save_snapshot is:
>
> save_snapshot
> migration_is_blocked
> qemu_savevm_state
> migration_is_blocked
>
> Since qemu_savevm_state is only called in save_snapshot, this means
> migration_is_blocked has been already checked.
>
> Signed-off-by: Wei Yang <address@hidden>
Queued 1,3,4
> ---
> migration/savevm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 92af2471cd..2eea604624 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1412,10 +1412,6 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
> return -EINVAL;
> }
>
> - if (migration_is_blocked(errp)) {
> - return -EINVAL;
> - }
> -
> if (migrate_use_block()) {
> error_setg(errp, "Block migration and snapshots are incompatible");
> return -EINVAL;
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK