[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 07/11] target/arm: add LOG_UNIMP messages to
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [RFC PATCH 07/11] target/arm: add LOG_UNIMP messages to arm-semi |
Date: |
Tue, 14 May 2019 18:15:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/14/19 5:52 PM, Alex Bennée wrote:
> Clean-up our unimplemented bits with a proper message.
>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/arm/arm-semi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c
> index 253c66b172a..a3bbef18ef7 100644
> --- a/target/arm/arm-semi.c
> +++ b/target/arm/arm-semi.c
> @@ -28,6 +28,7 @@
> #include "cpu.h"
> #include "hw/semihosting/semihost.h"
> #include "hw/semihosting/console.h"
> +#include "qemu/log.h"
> #ifdef CONFIG_USER_ONLY
> #include "qemu.h"
>
> @@ -366,7 +367,7 @@ target_ulong do_arm_semihosting(CPUARMState *env)
> return len - ret;
> }
> case TARGET_SYS_READC:
> - /* XXX: Read from debug console. Not implemented. */
> + qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__);
> return 0;
> case TARGET_SYS_ISTTY:
> GET_ARG(0);
> @@ -400,7 +401,7 @@ target_ulong do_arm_semihosting(CPUARMState *env)
> return buf.st_size;
> }
> case TARGET_SYS_TMPNAM:
> - /* XXX: Not implemented. */
> + qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__);
> return -1;
> case TARGET_SYS_REMOVE:
> GET_ARG(0);
>
- [Qemu-devel] [RFC PATCH 03/11] semihosting: implement a semihosting console, (continued)
- [Qemu-devel] [RFC PATCH 03/11] semihosting: implement a semihosting console, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 05/11] target/arm: fixup some of the commentary for arm-semi, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 10/11] target/mips: convert UHI_plog to use common semihosting code, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 04/11] semihosting: enable chardev backed output for console, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 06/11] target/arm: use the common interface for WRITE0/WRITEC in arm-semi, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 01/11] semihosting: move semihosting configuration into its own directory, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 07/11] target/arm: add LOG_UNIMP messages to arm-semi, Alex Bennée, 2019/05/14
- Re: [Qemu-devel] [RFC PATCH 07/11] target/arm: add LOG_UNIMP messages to arm-semi,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [RFC PATCH 08/11] target/arm: correct return values for WRITE/READ in arm-semi, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 09/11] target/mips: only build mips-semi for softmmu, Alex Bennée, 2019/05/14
- [Qemu-devel] [RFC PATCH 11/11] MAINTAINERS: update for semihostings new home, Alex Bennée, 2019/05/14
- Re: [Qemu-devel] [RFC PATCH 00/11] semihosting cleanup and re-factor, Alex Bennée, 2019/05/20