[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/16] migration: not necessary to check ops again
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 02/16] migration: not necessary to check ops again |
Date: |
Tue, 14 May 2019 19:34:40 +0100 |
From: Wei Yang <address@hidden>
During each iteration, se->ops is checked before each loop. So it is not
necessary to check it again and simplify the following check a little.
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/savevm.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 34bcad3807..587fec8ce2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1157,15 +1157,13 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool
postcopy)
if (!se->ops || !se->ops->save_live_iterate) {
continue;
}
- if (se->ops && se->ops->is_active) {
- if (!se->ops->is_active(se->opaque)) {
- continue;
- }
+ if (se->ops->is_active &&
+ !se->ops->is_active(se->opaque)) {
+ continue;
}
- if (se->ops && se->ops->is_active_iterate) {
- if (!se->ops->is_active_iterate(se->opaque)) {
- continue;
- }
+ if (se->ops->is_active_iterate &&
+ !se->ops->is_active_iterate(se->opaque)) {
+ continue;
}
/*
* In the postcopy phase, any device that doesn't know how to
--
2.21.0
- [Qemu-devel] [PULL 00/16] migration queue, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 01/16] migration: comment VMSTATE_UNUSED*() properly, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 02/16] migration: not necessary to check ops again,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 03/16] migration: remove not used field xfer_limit, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 04/16] vmstate: check subsection_found is enough, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 05/16] migration: savevm: fix error code with migration blockers, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 06/16] migration/colo.c: Remove redundant input parameter, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 07/16] migration/colo.h: Remove obsolete codes, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 08/16] qemu-option.hx: Update missed parameter for colo-compare, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 09/16] migration/ram.c: start of migration_bitmap_sync_range is always 0, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 10/16] migration: update comments of migration bitmap, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 11/16] migration/savevm: remove duplicate check of migration_is_blocked, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 12/16] migration/savevm: load_header before load_setup, Dr. David Alan Gilbert (git), 2019/05/14