[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) wi
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra |
Date: |
Wed, 15 May 2019 09:34:52 +0100 |
User-agent: |
mu4e 1.3.1; emacs 26.1 |
Jon Doron <address@hidden> writes:
> Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> gdbstub.c | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index c47ef7dd9c..89f1ab6524 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext
> *gdb_ctx, void *user_ctx)
> put_packet(gdb_ctx->s, "OK");
> }
>
> +static void handle_continue(GdbCmdContext *gdb_ctx, void *user_ctx)
> +{
> + if (gdb_ctx->num_params) {
> + gdb_set_cpu_pc(gdb_ctx->s, gdb_ctx->params[0].val_ull);
> + }
> +
> + gdb_ctx->s->signal = 0;
> + gdb_continue(gdb_ctx->s);
> +}
> +
> static int gdb_handle_packet(GDBState *s, const char *line_buf)
> {
> CPUState *cpu;
> @@ -1558,13 +1568,16 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> gdb_breakpoint_remove_all();
> break;
> case 'c':
> - if (*p != '\0') {
> - addr = strtoull(p, (char **)&p, 16);
> - gdb_set_cpu_pc(s, addr);
> + {
> + static const GdbCmdParseEntry continue_cmd_desc = {
> + .handler = handle_continue,
> + .cmd = "c",
> + .cmd_startswith = 1,
> + .schema = "L0"
> + };
> + cmd_parser = &continue_cmd_desc;
> }
> - s->signal = 0;
> - gdb_continue(s);
> - return RS_IDLE;
> + break;
> case 'C':
> s->signal = gdb_signal_to_target (strtoul(p, (char **)&p, 16));
> if (s->signal == -1)
--
Alex Bennée
- [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 01/27] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/02
- Re: [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra,
Alex Bennée <=
- [Qemu-devel] [PATCH v9 14/27] gdbstub: Implement read all registers (g pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 17/27] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/02