Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

[Peter Maydell]

On Tue, 14 May 2019 at 20:16, Aleksandar Markovic
<address@hidden> wrote:
>
> On May 13, 2019 11:14 PM, "Richard Henderson" <address@hidden>
> wrote:
> >
> > On 5/11/19 5:47 AM, Aleksandar Markovic wrote:
> > > If no, the patch shoud be amended. If yes, the commit message should be
> > > extended.
> >
> > Like what?  I think it's pretty clear as is.
> >
>
> Richard, no. In this case, there is a glaring discrepancy between the title
> and the functionality that the change provides. Much better title would be
> “configure: Disable slirp if no system mode target is selected”.
>
> I leave it to you to find out what can be improved in the commit message.

Aleksandar: I think this is not really a very productive stance to take.
Richard thinks the commit message is reasonable. If you have something
you would like him to change, I think we will reach a useful endpoint
much more quickly and smoothly if you suggest some new text, rather than
effectively saying "you need to think of something, and I'm going to keep
making you rewrite it until you telepathically figure out what the text
I wanted you to write is".

thanks
-- PMM