[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/6] target/m68k: Optimize rotate_x() using extract_i
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 6/6] target/m68k: Optimize rotate_x() using extract_i32() |
Date: |
Fri, 17 May 2019 00:35:19 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the
'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(),
free it with tcg_temp_free_i32().
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target/m68k/translate.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index bf700c01b1..f0534a4ba0 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -3693,6 +3693,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, int
size)
tcg_gen_sub_i32(shl, shl, shift); /* shl = size + 1 - shift */
tcg_gen_sub_i32(shx, sz, shift); /* shx = size - shift */
}
+ tcg_temp_free_i32(sz);
/* reg = (reg << shl) | (reg >> shr) | (x << shx); */
@@ -3708,9 +3709,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, int
size)
/* X = (reg >> size) & 1 */
X = tcg_temp_new();
- tcg_gen_shr_i32(X, reg, sz);
- tcg_gen_andi_i32(X, X, 1);
- tcg_temp_free(sz);
+ tcg_gen_extract_i32(X, reg, size, 1);
return X;
}
--
2.20.1
- [Qemu-devel] [PULL 0/6] M68k staging patches, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 1/6] target/m68k: In dump_address_map() check for memory access failures, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 2/6] target/m68k: In get_physical_address() check for memory access failures, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 5/6] target/m68k: Fix a tcg_temp leak, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 3/6] target/m68k: Switch to transaction_failed hook, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 4/6] target/m68k: Reduce the l1 TCGLabel scope, Laurent Vivier, 2019/05/16
- [Qemu-devel] [PULL 6/6] target/m68k: Optimize rotate_x() using extract_i32(),
Laurent Vivier <=
- Re: [Qemu-devel] [PULL 0/6] M68k staging patches, Peter Maydell, 2019/05/17