Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

[Wei Yang]

On Fri, May 17, 2019 at 04:29:03PM +0200, Igor Mammedov wrote:
>On Fri, 17 May 2019 12:59:57 +0000
>Wei Yang <address@hidden> wrote:
>
>> On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote:
>> >On Fri, 17 May 2019 08:51:14 +0800
>> >Wei Yang <address@hidden> wrote:
>> >
>> >> Pointed out by Philippe Mathieu-Daud?? <address@hidden>.
>> >> 
>> >> Signed-off-by: Wei Yang <address@hidden>
>> >> ---
>> >>  hw/acpi/Kconfig | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> 
>> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
>> >> index 7265843cc3..7c59cf900b 100644
>> >> --- a/hw/acpi/Kconfig
>> >> +++ b/hw/acpi/Kconfig
>> >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
>> >>  
>> >>  config ACPI_PCI
>> >>      bool
>> >> -    depends on ACPI
>> >> +    depends on ACPI && PCI
>> >>  
>> >>  config ACPI_VMGENID
>> >>      bool
>> >
>> >are you sure you didn't miss anything?
>> >
>> 
>> This patch is based on the comment in
>> http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913
>> 
>> My understanding is not correct?
>
>That wasn't the end of discussion, it continued on until Philippe suggested
>the below changes
>

Yep, just see the latest reply.

>> 
>> >On Fri, 17 May 2019 10:37:42 +0200
>> >Philippe Mathieu-Daud?? <address@hidden> wrote:
>> >
>> >[...]
>> >> 
>> >> config ARM_VIRT
>> >>     ...
>> >>     select ACPI_PCI
>> >> 
>> >> config ACPI_PCI
>> >>     bool
>> >>     depends on ACPI && PCI
>> >> 
>> >
>> >
>> 

-- 
Wei Yang
Help you, Help me