[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g pkt) with new infra |
Date: |
Tue, 21 May 2019 12:59:41 +0300 |
Signed-off-by: Jon Doron <address@hidden>
---
gdbstub.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 1afad31b49..781f5882ac 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1760,6 +1760,21 @@ static void handle_write_all_regs(GdbCmdContext
*gdb_ctx, void *user_ctx)
put_packet(gdb_ctx->s, "OK");
}
+static void handle_read_all_regs(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ target_ulong addr, len;
+
+ cpu_synchronize_state(gdb_ctx->s->g_cpu);
+ len = 0;
+ for (addr = 0; addr < gdb_ctx->s->g_cpu->gdb_num_g_regs; addr++) {
+ len += gdb_read_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf + len,
+ addr);
+ }
+
+ memtohex(gdb_ctx->str_buf, gdb_ctx->mem_buf, len);
+ put_packet(gdb_ctx->s, gdb_ctx->str_buf);
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1767,7 +1782,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
CPUClass *cc;
const char *p;
uint32_t pid, tid;
- int ch, reg_size, type, res;
+ int ch, type, res;
uint8_t mem_buf[MAX_PACKET_LENGTH];
char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
char thread_id[16];
@@ -1926,14 +1941,14 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
}
break;
case 'g':
- cpu_synchronize_state(s->g_cpu);
- len = 0;
- for (addr = 0; addr < s->g_cpu->gdb_num_g_regs; addr++) {
- reg_size = gdb_read_register(s->g_cpu, mem_buf + len, addr);
- len += reg_size;
+ {
+ static const GdbCmdParseEntry read_all_regs_cmd_desc = {
+ .handler = handle_read_all_regs,
+ .cmd = "g",
+ .cmd_startswith = 1
+ };
+ cmd_parser = &read_all_regs_cmd_desc;
}
- memtohex(buf, mem_buf, len);
- put_packet(s, buf);
break;
case 'G':
{
--
2.21.0
- [Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T pkt) with new infra, (continued)
- [Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 02/20] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 04/20] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 05/20] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 09/20] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 10/20] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 12/20] gdbstub: Implement write all registers (G pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v10 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 14/20] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 15/20] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 16/20] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 20/20] gdbstub: Implement qemu physical memory mode, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 18/20] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra, Jon Doron, 2019/05/21
- Re: [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler, Alex Bennée, 2019/05/23