[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 18/21] build: don't build hardware objects with l
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PULL 18/21] build: don't build hardware objects with linux-user |
Date: |
Tue, 21 May 2019 13:54:08 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Tue, May 21, 2019 at 02:52:42PM +0200, Laurent Vivier wrote:
> On 21/05/2019 13:52, Daniel P. Berrangé wrote:
> > On Wed, May 15, 2019 at 10:50:30PM +0200, Paolo Bonzini wrote:
> > > From: Laurent Vivier <address@hidden>
> > >
> > > Some objects are only needed for system emulation and tools.
> > > We can ignore them for the user mode case
> > >
> > > Update tests to run accordingly: conditionally build some tests
> > > on CONFIG_BLOCK.
> > >
> > > Some tests use components that are only built when softmmu or
> > > block tools are enabled, not for linux-user. So, if these components
> > > are not available, disable the tests.
> > >
> > > Signed-off-by: Laurent Vivier <address@hidden>
> > > Message-Id: <address@hidden>
> > > ---
> > > Makefile | 4 +++
> > > Makefile.objs | 14 +++++---
> > > tests/Makefile.include | 90
> > > +++++++++++++++++++++++++-------------------------
> > > 3 files changed, 58 insertions(+), 50 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 1851f8c..155f066 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -87,6 +87,10 @@ endif
> > > include $(SRC_PATH)/rules.mak
> > > +# notempy and lor are defined in rules.mak
> > > +CONFIG_TOOLS := $(call notempty,$(TOOLS))
> > > +CONFIG_BLOCK := $(call lor,$(CONFIG_SOFTMMU),$(CONFIG_TOOLS))
> >
> > IMHO calling this CONFIG_BLOCK is a really poor choice, as
> > the decision is completely unrelated to block modules. It
> > made really confused when trying to understand why all the
> > crypto or auth code had been made conditional on the block
> > drivers. The block code is just one part of QEMU that
> > is used in tools & softmmu.
> >
> > It would be better as CONFIG_SOFTMMU_TOOLS, or
> > CONFIG_NOT_USER, or something else.
>
> Do you think it's worth a patch to change the name?
Personally I'd like to see a patch to give it a better name.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PULL 13/21] sun4m: obey -vga none, (continued)
- [Qemu-devel] [PULL 13/21] sun4m: obey -vga none, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 14/21] trace: only include trace-event-subdirs when they are needed, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 20/21] hw/char: Move multi-serial devices into separate file, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 17/21] build: chardev is only needed for softmmu targets, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 15/21] build: replace GENERATED_FILES by generated-files-y, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 16/21] configure: qemu-ga is only needed with softmmu targets, Paolo Bonzini, 2019/05/15
- [Qemu-devel] [PULL 18/21] build: don't build hardware objects with linux-user, Paolo Bonzini, 2019/05/15
[Qemu-devel] [PULL 21/21] hw/net/ne2000: Extract the PCI device from the chipset common code, Paolo Bonzini, 2019/05/15
Re: [Qemu-devel] [PULL 00/21] Misc patches for 2019-05-15, Peter Maydell, 2019/05/16