[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v2 21/36] pci: Simplify pci_bus_is_root()

From: David Gibson
Subject: Re: [Qemu-devel] [PULL v2 21/36] pci: Simplify pci_bus_is_root()
Date: Wed, 22 May 2019 16:11:21 +1000
User-agent: Mutt/1.11.4 (2019-03-13)

On Mon, May 20, 2019 at 07:11:09PM -0400, Michael S. Tsirkin wrote:
> From: David Gibson <address@hidden>
> pci_bus_is_root() currently relies on a method in the PCIBusClass.
> But it's always known if a PCI bus is a root bus when we create it, so
> using a dynamic method is overkill.
> This replaces it with an IS_ROOT bit in a new flags field, which is set on
> root buses and otherwise clear.  As a bonus this removes the special
> is_root logic from pci_expander_bridge, since it already creates its bus
> as a root bus.
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> Message-Id: <address@hidden>

Michael, is there a particular reason this and the mmcfg patch went
in, but not the later patches in my PCI-E cleanup series?

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]