[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: Enable IA32_MISC_ENABLE MWAIT bit when ex
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] i386: Enable IA32_MISC_ENABLE MWAIT bit when exposing mwait/monitor |
Date: |
Wed, 22 May 2019 12:29:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 20/05/19 23:05, Eduardo Habkost wrote:
> What if enable_cpu_pm is false but we're running TCG, or if
> enable_cpu_pm is true but we're not using -cpu host?
>
> Shouldn't this be conditional on
> (env->features[FEAT_1_ECX] & CPUID_EXT_MONITOR)
> instead?
Yes, it should. I fixed it locally.
Paolo