Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

[Richard Henderson]

On 5/21/19 11:04 AM, Daniel P. Berrangé wrote:
> On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote:
>> For user-only, we require only the random number bits of the
>> crypto subsystem.  Rename crypto-aes-obj-y to crypto-user-obj-y,
>> and add the random number objects, plus init.o to handle any
>> extra stuff the crypto library requires.
> 
> If you pull in my authz patch first:
> 
>   https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg04863.html
> 
> then we can just kill crypto-aes-obj-y entirely, and make
> linux-user reference crypto-obj-y as normal. My patch avoids
> pulling in PAM, and your previous patch takes care of the
> static linking problem.

You would think so, wouldn't you.  And yet, not.

  CC      authz/base.o
/home/rth/qemu/qemu/authz/base.c:23:10: fatal error: trace.h: No such file or
directory
 #include "trace.h"
          ^~~~~~~~~
compilation terminated.

We're missing some dependency somewhere, and I have no idea what's missing.

This for

../qemu/configure --static --disable-system --disable-tools

I have a working configuration here in v8.  Can we please leave the bikeshed
unpainted for the moment and you can adjust the makefiles as you see fit 
afterward?

Otherwise, I'll pass the entire series off to you and leave it at that.


r~