[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init |
Date: |
Wed, 22 May 2019 14:42:06 -0400 |
Avoids leaking the /dev/urandom fd into any child processes.
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
crypto/random-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/random-platform.c b/crypto/random-platform.c
index 260b64564d..6df40744c7 100644
--- a/crypto/random-platform.c
+++ b/crypto/random-platform.c
@@ -42,9 +42,9 @@ int qcrypto_random_init(Error **errp)
#else
/* TBD perhaps also add support for BSD getentropy / Linux
* getrandom syscalls directly */
- fd = open("/dev/urandom", O_RDONLY);
+ fd = open("/dev/urandom", O_RDONLY | O_CLOEXEC);
if (fd == -1 && errno == ENOENT) {
- fd = open("/dev/random", O_RDONLY);
+ fd = open("/dev/random", O_RDONLY | O_CLOEXEC);
}
if (fd < 0) {
--
2.17.1
- [Qemu-devel] [PULL 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, (continued)
- [Qemu-devel] [PULL 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 03/25] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 25/25] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 23/25] target/ppc: Use gen_io_start/end around DARN, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 11/25] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 22/25] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 16/25] linux-user: Remove srand call, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init,
Richard Henderson <=
- [Qemu-devel] [PULL 06/25] crypto: Use getrandom for qcrypto_random_bytes, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 08/25] ui/vnc: Split out authentication_failed, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 24/25] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 21/25] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 13/25] linux-user: Call qcrypto_init if not using -seed, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 12/25] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/22