[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] net/announce: Allow optional list of interf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] net/announce: Allow optional list of interfaces |
Date: |
Thu, 23 May 2019 11:33:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/23/19 9:58 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Allow the caller to restrict the set of interfaces that announces are
> sent on. The default is still to send on all interfaces.
>
> e.g.
>
> { "execute": "announce-self", "arguments": { "initial": 50, "max": 550,
> "rounds": 5, "step": 50, "ifaces": ["vn2","vn1"] } }
>
> Note: There's still only one timer for the qmp command, so that
> performing an 'announce-self' on one list of interfaces followed
> by another 'announce-self' on another list will stop the announces
> on the existing set.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> +++ b/qapi/net.json
> @@ -706,7 +706,8 @@
> 'data': { 'initial': 'int',
> 'max': 'int',
> 'rounds': 'int',
> - 'step': 'int' } }
> + 'step': 'int',
> + '*ifaces': ['str'] } }
Missing documentation for the addition, including a '(since 4.1)' tag.
>
> ##
> # @announce-self:
> @@ -718,9 +719,10 @@
> #
> # Example:
> #
> -# -> { "execute": "announce-self"
> +# -> { "execute": "announce-self",
> # "arguments": {
> -# "initial": 50, "max": 550, "rounds": 10, "step": 50 } }
> +# "initial": 50, "max": 550, "rounds": 10, "step": 50,
> +# "ifaces": ["vn2","vn3"] } }
> # <- { "return": {} }
> #
> # Since: 4.0
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature