[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to includ
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/ |
|
Date: |
Fri, 24 May 2019 09:32:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/24/19 9:24 AM, Thomas Huth wrote:
> On 23/05/2019 10.15, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Please add a proper patch description. You don't really expect someone
> to review this monster patch without instructions where to look first?
>From the cover letter:
PATCH 5 adds the tests, but only for include/. 764 headers, 179
known-bad. We may decide to clean up include/ some before we apply
PATCH 6+7.
PATCH 6 extends them to all headers, except for generated ones. Adds
797 headers, 409 known-bad.
Markus, you could have use "This patch is RFC, see the cover letter of
this series" :)
- [Qemu-devel] [RFC v4 5/7] tests: New make target check-source, (continued)
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source, Philippe Mathieu-Daudé, 2019/05/24
[Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/, Markus Armbruster, 2019/05/23