Re: [Qemu-devel] [PATCH] Regression for m68k causing Single-Step via GDB/RSP to not single step

[Laurent Vivier]

On 26/05/2019 09:50, Lucien Murray-Pitts wrote:
> A regression that was introduced, with the refactor to TranslatorOps,
> drops two lines that update the PC when single-stepping is being performed.
> ( short commit 11ab74b )
>
> This patch resolves that issue.
>
> Signed-off-by: Lucien Murray-Pitts <address@hidden>
> ---
>   target/m68k/translate.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index f0534a4ba0..2922ea79c3 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -6130,6 +6130,8 @@ static void m68k_tr_tb_stop(DisasContextBase *dcbase, 
> CPUState *cpu)
>           return;
>       }
>       if (dc->base.singlestep_enabled) {
> +        update_cc_op(dc);
> +        tcg_gen_movi_i32(QREG_PC, dc->pc);
>           gen_helper_raise_exception(cpu_env, tcg_const_i32(EXCP_DEBUG));
>           return;
>       }

Reviewed-by: Laurent Vivier <address@hidden>