[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" mac
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property |
Date: |
Mon, 27 May 2019 20:38:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Igor Mammedov <address@hidden> writes:
> '-numa mem' option has a number of issues and mgmt often defaults
> to it. Unfortunately it's no possible to replace it with an alternative
> '-numa memdev' without breaking migration compatibility.
To be precise: -numa node,mem=... and -numa node,memdev=... Correct?
> What's possible
> though is to deprecate it, keeping option working with old machine types.
> Once deprecation period expires, QEMU will disable '-numa mem' option,
> usage on new machine types and when the last machine type that supported
> it is removed we would be able to remove '-numa mem' with associated code.
>
> In order to help mgmt to find out if being deprecated CLI option
> '-numa mem=SZ' is still supported by particular machine type, expose
> this information via "numa-mem-supported" machine property.
>
> Users can use "qom-list-properties" QMP command to list machine type
> properties including initial proprety values (when probing for supported
> machine types with '-machine none') or at runtime at preconfig time
> before numa mapping is configured and decide if they should used legacy
> '-numa mem' or alternative '-numa memdev' option.
This sentence is impenetrable, I'm afraid :)
If we only want to convey whether a machine type supports -numa
node,mem=..., then adding a flag to query-machines suffices. Since I'm
pretty sure you'd have figured that out yourself, I suspect I'm missing
something. Can you give me some examples of intended usage?
- [Qemu-devel] [PATCH v3 0/6] numa: deprecate '-numa node, mem' and default memory distribution, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size(), Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 3/6] qmp: qmp_qom_list_properties(): ignore empty string options, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 5/6] numa: deprecate 'mem' parameter of '-numa node' option, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 6/6] numa: deprecate implict memory distribution between nodes, Igor Mammedov, 2019/05/17