qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 03/11] numa: move numa global variable numa_i


From: Tao Xu
Subject: Re: [Qemu-devel] [PATCH v4 03/11] numa: move numa global variable numa_info into MachineState
Date: Tue, 28 May 2019 15:43:03 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1


On 23/05/2019 21:47, Igor Mammedov wrote:
On Wed,  8 May 2019 14:17:18 +0800
Tao Xu <address@hidden> wrote:

...
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 8ff08814fd..845b737ab9 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -602,7 +602,7 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info 
*binfo,
      if (nb_numa_nodes > 0) {
          mem_base = binfo->loader_start;
          for (i = 0; i < nb_numa_nodes; i++) {
-            mem_len = numa_info[i].node_mem;
+            mem_len = ms->numa_state->nodes[i].node_mem;
in 1/11 I've suggested to add nb_numa_nodes, but it might be to add
a pointer to MachineState there.
It would also help to simplify arm_load_dtb later as there are other
bits that we copy to arm_boot_info from MachineState.


Hi Igor,

Thank you for your review. I will simplify arm_load_dtb() in the next version of patch and improve the other issues.

Tao



reply via email to

[Prev in Thread] Current Thread [Next in Thread]