Re: [Qemu-devel] [PATCH 1/2] migration: Fix fd protocol for incoming defer

[Juan Quintela]

Yury Kotov <address@hidden> wrote:
> Currently, incoming migration through fd supports only command-line case:
> E.g.
>     fork();
>     fd = open();
>     exec("qemu ... -incoming fd:%d", fd);
>
> It's possible to use add-fd commands to pass fd for migration, but it's
> invalid case. add-fd works with fdset but not with particular fds.
>
> To work with getfd in incoming defer it's enough to use monitor_fd_param
> instead of strtol. monitor_fd_param supports both cases:
> * fd:123
> * fd:fd_name (added by getfd).
>
> Signed-off-by: Yury Kotov <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

Not only that, it also improves error messages.