[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/16] tcg/i386: Use MOVDQA for TCG_TYPE_V128 loa
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PULL 16/16] tcg/i386: Use MOVDQA for TCG_TYPE_V128 load/store |
Date: |
Tue, 28 May 2019 16:34:29 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/28/19 1:46 PM, David Hildenbrand wrote:
> FWIW, this seems to be the easiest way:
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index f0d9a6a36d..d363ae0fb3 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -66,7 +66,7 @@ struct CPUS390XState {
> * The floating point registers are part of the vector registers.
> * vregs[0][0] -> vregs[15][0] are 16 floating point registers
> */
> - CPU_DoubleU vregs[32][2]; /* vector registers */
> + CPU_DoubleU vregs[32][2] QEMU_ALIGNED(16); /* vector registers */
> uint32_t aregs[16]; /* access registers */
> uint8_t riccb[64]; /* runtime instrumentation control */
> uint64_t gscb[4]; /* guarded storage control */
>
>
> Makes it work for me again.
That's the right fix, and exactly the bug that I was hoping to find with
11e2bfef7990 ("tcg/i386: Use MOVDQA for TCG_TYPE_V128 load/store").
r~
- [Qemu-devel] [PULL 05/16] tcg: Introduce do_op3_nofail for vector expansion, (continued)
- [Qemu-devel] [PULL 05/16] tcg: Introduce do_op3_nofail for vector expansion, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 07/16] tcg: Add TCG_OPF_NOT_PRESENT if TCG_TARGET_HAS_foo is negative, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 14/16] tcg/aarch64: Build vector immediates with two insns, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 09/16] tcg/i386: Remove expansion for missing minmax, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 10/16] tcg/i386: Use umin/umax in expanding unsigned compare, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 13/16] tcg/aarch64: Use MVNI in tcg_out_dupi_vec, Richard Henderson, 2019/05/22
- [Qemu-devel] [PULL 16/16] tcg/i386: Use MOVDQA for TCG_TYPE_V128 load/store, Richard Henderson, 2019/05/22
[Qemu-devel] [PULL 11/16] tcg/aarch64: Support vector bitwise select value, Richard Henderson, 2019/05/22
[Qemu-devel] [PULL 12/16] tcg/aarch64: Split up is_fimm, Richard Henderson, 2019/05/22
[Qemu-devel] [PULL 15/16] tcg/aarch64: Allow immediates for vector ORR and BIC, Richard Henderson, 2019/05/22
Re: [Qemu-devel] [PULL 00/16] tcg queued patches, Aleksandar Markovic, 2019/05/23
Re: [Qemu-devel] [PULL 00/16] tcg queued patches, Peter Maydell, 2019/05/24
Re: [Qemu-devel] [PULL 00/16] tcg queued patches, David Hildenbrand, 2019/05/28