Re: [Qemu-devel] [PATCH 3/4] migration/ram.c: MultiFDSendParams.sem_sync is not really used

[Wei Yang]

On Tue, May 28, 2019 at 10:16:06AM +0200, Juan Quintela wrote:
>Wei Yang <address@hidden> wrote:
>> Besides init and destroy, MultiFDSendParams.sem_sync is not really used.
>>
>> Signed-off-by: Wei Yang <address@hidden>
>
>Reviewed-by: Juan Quintela <address@hidden>
>
>I mad SendParamas and RecvParams identical, but they are different.  You
>are right.

Thanks.

BTW, I found some interesting thing about multifd_send_state->channels_ready.
By checking the value of this semaphore, it grows far beyond what we really
have.

For example, we have default 2 channels which means
multifd_send_state->channels_ready's value is no more than 2. But the actual
value could go to more than 30.

The behavior sounds not right.

-- 
Wei Yang
Help you, Help me