[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Headers without multiple inclusion guards
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Headers without multiple inclusion guards |
Date: |
Wed, 29 May 2019 14:55:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Anthony PERARD <address@hidden> writes:
> On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote:
>> Just in case: what's a multiple inclusion guard? It's
>>
>> #ifndef UNIQUE_GUARD_SYMBOL_H
>> #define UNIQUE_GUARD_SYMBOL_H
>> ...
>> #endif
>>
>> with nothing but comments outside the conditional, so that the header
>> can safely be included more than once.
>
>
>> Guest CPU Cores (Xen):
>> ----------------------
>>
>> X86
>> M: Stefano Stabellini <address@hidden>
>> M: Anthony Perard <address@hidden>
>> M: Paul Durrant <address@hidden>
>> include/hw/xen/io/ring.h
>
> That file does have a guard, it's __XEN_PUBLIC_IO_RING_H__
>
> Do you (or the checker) want it to be changed to XEN_PUBLIC_IO_RING_H ?
Yes. I'll post a patch.
>> virtio-9p
>> M: Greg Kurz <address@hidden>
>> hw/9pfs/xen-9pfs.h
>
> Stefano, is the missing inclusion guard was intentional? Otherwise, I
> can send a patch for it.
Sending a patch is okay, but telling me "unintential, please fix it
along with the other ones" is also okay :)
Thanks!
- Re: [Qemu-devel] Headers without multiple inclusion guards, (continued)
- Re: [Qemu-devel] Headers without multiple inclusion guards, Richard Henderson, 2019/05/28
- Re: [Qemu-devel] Headers without multiple inclusion guards, BALATON Zoltan, 2019/05/28
- Re: [Qemu-devel] Headers without multiple inclusion guards, David Gibson, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Laurent Vivier, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Bastian Koppelmann, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Cornelia Huck, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Greg Kurz, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Alex Bennée, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Anthony PERARD, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards,
Markus Armbruster <=
- Re: [Qemu-devel] Headers without multiple inclusion guards, David Hildenbrand, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Philippe Mathieu-Daudé, 2019/05/29