Re: [Qemu-devel] [PATCH v3 00/14] tests/vm: serial console autoinstall, misc fixes.

[Alex Bennée]

address@hidden writes:

> Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PATCH v3 00/14] tests/vm: serial console autoinstall, 
> misc fixes.
> Message-id: address@hidden
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> From https://github.com/patchew-project/qemu
>    1b46b4daa6..6d8e75d41c  master     -> master
> From https://github.com/patchew-project/qemu
>  * [new tag]               patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 6f7f5d5a99 tests/vm: ubuntu.i386: apt proxy setup
> ef70a753bb tests/vm: fedora autoinstall, using serial console
> 0debc608fb tests/vm: netbsd autoinstall, using serial console
> 5e005a2c07 tests/vm: freebsd autoinstall, using serial console
> bff0400f4e tests/vm: openbsd autoinstall, using serial console
> 59085882aa tests/vm: serial console support helpers
> 27ef52c336 tests/vm: add DEBUG=1 to help text
> 128b742fc5 tests/vm: add vm-boot-{ssh, serial}-<guest> targets
> 2eb095b079 tests/vm: proper guest shutdown
> 4f3a1fed99 tests/vm: run test builds on snapshot
> d3850e7e8e tests/vm: use ssh with pty unconditionally
> 9d18c76436 tests/vm: send proxy environment variables over ssh
> 9bb50d9be2 tests/vm: python3 fixes
> 76e6f4270e scripts: use git archive in archive-source
>
> === OUTPUT BEGIN ===
> 1/14 Checking commit 76e6f4270ef3 (scripts: use git archive in archive-source)
> ERROR: code indent should never use tabs
> #41: FILE: scripts/archive-source.sh:36:
> +^Igit submodule deinit $sub_deinit$
>
> ERROR: code indent should never use tabs
> #68: FILE: scripts/archive-source.sh:56:
> +^I-*)$
>
> ERROR: code indent should never use tabs
> #69: FILE: scripts/archive-source.sh:57:
> +^I    sub_deinit="$sub_deinit $sm"$
>
> ERROR: code indent should never use tabs
> #70: FILE: scripts/archive-source.sh:58:
> +^I    git submodule update --init "$sm"$
>
> ERROR: code indent should never use tabs
> #71: FILE: scripts/archive-source.sh:59:
> +^I    test $? -ne 0 && error "failed to update submodule $sm"$
>
> ERROR: code indent should never use tabs
> #72: FILE: scripts/archive-source.sh:60:
> +^I    ;;$
>
> ERROR: code indent should never use tabs
> #73: FILE: scripts/archive-source.sh:61:
> +^I+*)$
>
> ERROR: code indent should never use tabs
> #74: FILE: scripts/archive-source.sh:62:
> +^I    echo "WARNING: submodule $sm is out of sync"$
>
> ERROR: code indent should never use tabs
> #75: FILE: scripts/archive-source.sh:63:
> +^I    ;;$
>
> total: 9 errors, 0 warnings, 93 lines checked

I'll fix these up but it might be worth seeing how that crept into your
editor? I'll include an update to editorconfig while I'm at it.

--
Alex Bennée