[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly |
Date: |
Fri, 31 May 2019 04:22:40 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 5/27/19 10:39 AM, Yoshinori Sato wrote:
> On Fri, 24 May 2019 00:07:57 +0900,
> Richard Henderson wrote:
>> Obviously there are still a few inconsistencies in the
>> format strings used for the immediates, but the format
>> is readable and it is easy to look at the opcode to see
>> how our decode compares to the manual.
>>
>
> Hmm.
> The output of the immediate value should be the same as the output of objdump.
> I do not think that it is the proper format, but I did that because
> it was useful for comparing the results.
This is a fair comment.
Of course, we could also simultaneously fix inconsistencies in objdump. I
doubt that any of these cases are intentionally different.
Something for later, perhaps.
r~
- Re: [Qemu-devel] [PATCH 5/6] target/rx: Collect all bytes during disassembly, (continued)