Re: [Qemu-devel] [PATCH RFC v20 2/8] target/avr: Add instruction helpers

[Richard Henderson]

On 5/30/19 2:07 PM, Michael Rolnik wrote:
> From: Sarah Harris <address@hidden>
> 
> Stubs for unimplemented instructions and helpers for instructions that need 
> to interact with QEMU.
> SPM and WDR are unimplemented because they require emulation of complex 
> peripherals.
> The implementation of SLEEP is very limited due to the lack of peripherals to 
> generate wake interrupts.
> Memory access instructions are implemented here because some address ranges 
> actually refer to CPU registers.
> 
> Signed-off-by: Sarah Harris <address@hidden>
> Signed-off-by: Michael Rolnik <address@hidden>
> ---
>  target/avr/helper.c | 346 ++++++++++++++++++++++++++++++++++++++++++++
>  target/avr/helper.h |  28 ++++
>  2 files changed, 374 insertions(+)
>  create mode 100644 target/avr/helper.c
>  create mode 100644 target/avr/helper.h

Reviewed-by: Richard Henderson <address@hidden>


r~