Re: [Qemu-devel] [PATCH v1 16/23] s390x/tcg: Implement VECTOR FP MULTIPLY AND (ADD|SUBTRACT)

[David Hildenbrand]

On 31.05.19 19:42, Richard Henderson wrote:
> On 5/31/19 5:44 AM, David Hildenbrand wrote:
>> +typedef uint64_t (*vop64_4_fn)(uint64_t a, uint64_t b, uint64_t c,
>> +                               float_status *s);
>> +static void vop64_4(S390Vector *v1, const S390Vector *v2, const S390Vector 
>> *v3,
>> +                    const S390Vector *v4, CPUS390XState *env, bool s,
>> +                    vop64_4_fn fn, uintptr_t retaddr)
>> +{
> 
> Surely this is only going to be used for FMA/FMS.
> Why not just pass in the float_muladd_* constant
> to pass on to float64_muladd?

I actually had something similar before, but makes sense, as this will
really only be used for these functions.

Thanks!

> 
> 
> r~
> 


-- 

Thanks,

David / dhildenb