[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id |
|
Date: |
Fri, 31 May 2019 16:49:44 -0300 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Wed, May 29, 2019 at 06:07:47PM +0200, Laurent Vivier wrote:
> On pseries, core-ids are strongly binded to a node-id by the command
> line option. If an user tries to add a CPU to the wrong node, he has
> an error but it is not really helpful:
>
> qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
> -numa node,nodeid=0 -numa node,nodeid=1 ...
>
> (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
> Error: node-id=1 must match numa node specified with -numa option
>
> This patch improves this error message by giving to the user the good
> node-id to use with the core-id he's providing
>
> Error: invalid node-id, must be 0
>
> Signed-off-by: Laurent Vivier <address@hidden>
Queued, thanks.
--
Eduardo