[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Fix options leakage in i
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Fix options leakage in img_rebase() |
Date: |
Mon, 3 Jun 2019 18:15:11 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/28/19 3:53 PM, Max Reitz wrote:
> img_rebase() can leak a QDict in two occasions. Fix it.
>
> Coverity: CID 1401416
> Fixes: d16699b64671466b42079c45b89127aeea1ca565
> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-img.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index b0535919b1..86e1923acf 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -3347,6 +3347,7 @@ static int img_rebase(int argc, char **argv)
> out_baseimg,
> &local_err);
> if (local_err) {
> + qobject_unref(options);
> error_reportf_err(local_err,
> "Could not resolve backing filename: ");
> ret = -1;
> @@ -3359,7 +3360,9 @@ static int img_rebase(int argc, char **argv)
> */
> prefix_chain_bs = bdrv_find_backing_image(bs, out_real_path);
> if (prefix_chain_bs) {
> + qobject_unref(options);
> g_free(out_real_path);
> +
> blk_new_backing = blk_new(BLK_PERM_CONSISTENT_READ,
> BLK_PERM_ALL);
> ret = blk_insert_bs(blk_new_backing, prefix_chain_bs,
>
I was going to ask about the other branch after this one, but:
"The reference to the QDict belongs to the block layer after the call
(even on failure)"
"Oh, well... OK."
Reviewed-by: John Snow <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Fix options leakage in img_rebase(),
John Snow <=