[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] blockdev: Overlays are not
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] blockdev: Overlays are not snapshots |
|
Date: |
Tue, 04 Jun 2019 10:40:56 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 03 Jun 2019 10:22:34 PM CEST, Max Reitz wrote:
> QEMU’s always been confused over what a snapshot is: Is it the overlay?
> Is it the backing image?
>
> Confusion is rarely a good thing. I can’t think of any objective reason
> why the overlay would be a snapshot. A snapshot is something that does
> not change over time; the overlay does.
>
> (I suppose historically the reason is that “Taking an overlay” makes no
> sense, so the operations are called “Taking a snapshot”. Somehow, this
> meaning carried over to the new file that is created during that
> operation; if “Creating a snapshot” creates a file, that file must be
> the snapshot, right? Well, no, it isn’t.)
>
> Let’s fix this as best as we can. Better Nate than lever.
Reviewed-by: Alberto Garcia <address@hidden>
Berto