[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring |
Date: |
Wed, 05 Jun 2019 07:58:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Aarushi Mehta <address@hidden> writes:
> Option only enumerates for hosts that support it.
Blank line here, please. Same in other patches.
> Signed-off-by: Aarushi Mehta <address@hidden>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 1defcde048..db7eedd058 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2792,11 +2792,13 @@
> #
> # @threads: Use qemu's thread pool
> # @native: Use native AIO backend (only Linux and Windows)
> +# @io_uring: Use linux io_uring (since 4.1)
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native',
> + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ]
> }
We prefer '-' over '_' in the QAPI schema: 'io-uring' instead of
'io_uring'. Exceptions can be made when existing siblings use '_' (not
the case here), or to match how the thing is commonly spelled outside
QEMU. Up to the subject matter experts; I just want to make sure it's
not accidental.
>
> ##
> # @BlockdevCacheOptions:
- [Qemu-devel] [PATCH v4 7/9] blockdev: accept io_uring as option, (continued)
- [Qemu-devel] [PATCH v4 7/9] blockdev: accept io_uring as option, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 8/9] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 6/9] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 4/9] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 3/9] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 1/9] configure: permit use of io_uring, Aarushi Mehta, 2019/06/03
- [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/06/03
- Re: [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v4 0/9] Add support for io_uring, Sergio Lopez, 2019/06/07