[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr d
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly |
Date: |
Fri, 7 Jun 2019 15:43:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/7/19 11:11 AM, Yoshinori Sato wrote:
> From: Richard Henderson <address@hidden>
>
> Note that the ld == 3 case handled by prt_ldmi is decoded as
> XCHG_rr and cannot appear here.
>
> Reviewed-by: Yoshinori Sato <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Again:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Yoshinori Sato <address@hidden>
> ---
> target/rx/disas.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/target/rx/disas.c b/target/rx/disas.c
> index 515b365528..db10385fd0 100644
> --- a/target/rx/disas.c
> +++ b/target/rx/disas.c
> @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr
> *a)
> /* xchg dsp[rs].<mi>,rd */
> static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
> {
> - static const char msize[][4] = {
> - "b", "w", "l", "ub", "uw",
> - };
> - char dsp[8];
> -
> - rx_index_addr(ctx, dsp, a->ld, a->mi);
> - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
> + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
> return true;
> }
>
>
- [Qemu-devel] [PATCH v17 19/24] target/rx: Replace operand with prt_ldmi in disassembler, (continued)
- [Qemu-devel] [PATCH v17 19/24] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 13/24] target/rx: Fix cpu types and names, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 21/24] target/rx: Emit all disassembly in one prt(), Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 09/24] qemu/bitops.h: Add extract8 and extract16, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly, Yoshinori Sato, 2019/06/07
- Re: [Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v17 16/24] Add rx-softmmu, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 17/24] MAINTAINERS: Add RX, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 03/24] target/rx: CPU definition, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 06/24] hw/timer: RX62N internal timer modules, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 02/24] target/rx: TCG helper, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 15/24] hw/rx: Honor -accel qtest, Yoshinori Sato, 2019/06/07