qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 01/10] monitor: Remove unused password promp


From: Dr. David Alan Gilbert
Subject: Re: [Qemu-devel] [RFC PATCH 01/10] monitor: Remove unused password prompting fields
Date: Fri, 7 Jun 2019 16:39:20 +0100
User-agent: Mutt/1.11.4 (2019-03-13)

* Kevin Wolf (address@hidden) wrote:
> Commit 788cf9f8c removed the code for password prompting from the
> monitor. Since then, the Monitor fields password_completion_cb and
> password_opaque have been unused. Remove them.
> 
> Signed-off-by: Kevin Wolf <address@hidden>

A shame, I love the idea of password completion.  123<tab>

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  monitor.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index 6428eb3b7e..70ce9e8a77 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -220,8 +220,6 @@ struct Monitor {
>  
>      MonitorQMP qmp;
>      gchar *mon_cpu_path;
> -    BlockCompletionFunc *password_completion_cb;
> -    void *password_opaque;
>      mon_cmd_t *cmd_table;
>      QTAILQ_ENTRY(Monitor) entry;
>  
> -- 
> 2.20.1
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK



reply via email to

[Prev in Thread] Current Thread [Next in Thread]