[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/42] target/arm: Convert VFP comparison insns
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree |
Date: |
Sat, 8 Jun 2019 14:02:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/6/19 12:46 PM, Peter Maydell wrote:
> + vd = tcg_temp_new_i32();
> + vm = tcg_temp_new_i32();
> +
> + neon_load_reg32(vd, a->vd);
> + if (a->z) {
> + tcg_gen_movi_i32(vm, 0);
> + } else {
> + neon_load_reg32(vm, a->vm);
> + }
> +
> + if (a->e) {
> + gen_helper_vfp_cmpes(vd, vm, cpu_env);
> + } else {
> + gen_helper_vfp_cmps(vd, vm, cpu_env);
> + }
> + return true;
Missing the temp frees, again in the dp version. Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 31/42] target/arm: Convert VSQRT to decodetree, (continued)
- [Qemu-devel] [PATCH 04/42] target/arm: Fix Cortex-R5F MVFR values, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 22/42] target/arm: Convert VMUL to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 20/42] target/arm: Convert VFP VNMLS to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 36/42] target/arm: Convert VFP round insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree, Peter Maydell, 2019/06/06
- Re: [Qemu-devel] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree,
Richard Henderson <=
- [Qemu-devel] [PATCH 25/42] target/arm: Convert VSUB to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 37/42] target/arm: Convert double-single precision conversion insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 06/42] target/arm: Convert the VSEL instructions to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 34/42] target/arm: Convert the VCVT-from-f16 insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 07/42] target/arm: Convert VMINNM, VMAXNM to decodetree, Peter Maydell, 2019/06/06