Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
54dc0dd BootLinuxConsoleTest: Test the RX-Virt machine
a650693 MAINTAINERS: Add RX
bb5922e Add rx-softmmu
57efd99 hw/registerfields.h: Add 8bit and 16bit register macros
a043825 qemu/bitops.h: Add extract8 and extract16
b3d9518 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
dd0b312 hw/rx: Honor -accel qtest
7af162f hw/rx: RX Target hardware definition
52cee25 hw/char: RX62N serial communication interface (SCI)
bf4a215 hw/timer: RX62N internal timer modules
51cf815 hw/intc: RX62N interrupt controller (ICUa)
e0a06ae target/rx: Dump bytes for each insn during disassembly
cda7b7d target/rx: Collect all bytes during disassembly
75be3f5 target/rx: Emit all disassembly in one prt()
a4bbc9b target/rx: Use prt_ldmi for XCHG_mr disassembly
0d03cf7 target/rx: Replace operand with prt_ldmi in disassembler
efe02d6 target/rx: Disassemble rx_index_addr into a string
268ed0e target/rx: RX disassembler
4b87235 target/rx: CPU definition
8893379 target/rx: TCG helper
adee91c target/rx: TCG translation

=== OUTPUT BEGIN ===
1/21 Checking commit adee91cee710 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/21 Checking commit 8893379be728 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/21 Checking commit 4b8723519d74 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/21 Checking commit 268ed0ed5bed (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 4/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit efe02d640116 (target/rx: Disassemble rx_index_addr into a 
string)
6/21 Checking commit 0d03cf7c4dea (target/rx: Replace operand with prt_ldmi in 
disassembler)
7/21 Checking commit a4bbc9b6f906 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
8/21 Checking commit 75be3f594a61 (target/rx: Emit all disassembly in one prt())
9/21 Checking commit cda7b7deb78a (target/rx: Collect all bytes during 
disassembly)
10/21 Checking commit e0a06ae5bb91 (target/rx: Dump bytes for each insn during 
disassembly)
11/21 Checking commit 51cf8153697c (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/21 Checking commit bf4a2154e409 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 12/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/21 Checking commit 52cee25bb159 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/21 Checking commit 7af162fcb6fc (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit dd0b312cbbf0 (hw/rx: Honor -accel qtest)
16/21 Checking commit b3d951869f12 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
17/21 Checking commit a043825aeef2 (qemu/bitops.h: Add extract8 and extract16)
18/21 Checking commit 57efd991b11b (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 18/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/21 Checking commit bb5922e03944 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 19/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/21 Checking commit a650693b9b8f (MAINTAINERS: Add RX)
21/21 Checking commit 54dc0ddfce91 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden