[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 3/6] migration: Make multifd_load_setup() get an
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH v4 3/6] migration: Make multifd_load_setup() get an Error parameter |
Date: |
Wed, 12 Jun 2019 12:53:20 +0200 |
We need to change the full chain to pass the Error parameter.
Signed-off-by: Juan Quintela <address@hidden>
---
migration/migration.c | 10 +++++-----
migration/migration.h | 2 +-
migration/ram.c | 2 +-
migration/ram.h | 2 +-
migration/rdma.c | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 0ac504be3c..4246bdd661 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -513,11 +513,11 @@ fail:
exit(EXIT_FAILURE);
}
-static void migration_incoming_setup(QEMUFile *f)
+static void migration_incoming_setup(QEMUFile *f, Error **errp)
{
MigrationIncomingState *mis = migration_incoming_get_current();
- if (multifd_load_setup() != 0) {
+ if (multifd_load_setup(errp) != 0) {
/* We haven't been able to create multifd threads
nothing better to do */
exit(EXIT_FAILURE);
@@ -567,13 +567,13 @@ static bool postcopy_try_recover(QEMUFile *f)
return false;
}
-void migration_fd_process_incoming(QEMUFile *f)
+void migration_fd_process_incoming(QEMUFile *f, Error **errp)
{
if (postcopy_try_recover(f)) {
return;
}
- migration_incoming_setup(f);
+ migration_incoming_setup(f, errp);
migration_incoming_process();
}
@@ -591,7 +591,7 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error
**errp)
return;
}
- migration_incoming_setup(f);
+ migration_incoming_setup(f, errp);
/*
* Common migration only needs one channel, so we can start
diff --git a/migration/migration.h b/migration/migration.h
index 780a096857..71c03353c3 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -237,7 +237,7 @@ struct MigrationState
void migrate_set_state(int *state, int old_state, int new_state);
-void migration_fd_process_incoming(QEMUFile *f);
+void migration_fd_process_incoming(QEMUFile *f, Error **errp);
void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp);
void migration_incoming_process(void);
diff --git a/migration/ram.c b/migration/ram.c
index 4b65d22cb1..b0ca989160 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1370,7 +1370,7 @@ static void *multifd_recv_thread(void *opaque)
return NULL;
}
-int multifd_load_setup(void)
+int multifd_load_setup(Error **errp)
{
int thread_count;
uint32_t page_count = MULTIFD_PACKET_SIZE / qemu_target_page_size();
diff --git a/migration/ram.h b/migration/ram.h
index 09feaad55b..dd1a736417 100644
--- a/migration/ram.h
+++ b/migration/ram.h
@@ -44,7 +44,7 @@ uint64_t ram_bytes_total(void);
int multifd_save_setup(Error **errp);
void multifd_save_cleanup(void);
-int multifd_load_setup(void);
+int multifd_load_setup(Error **errp);
int multifd_load_cleanup(Error **errp);
bool multifd_recv_all_channels_created(void);
bool multifd_recv_new_channel(QIOChannel *ioc, Error **errp);
diff --git a/migration/rdma.c b/migration/rdma.c
index c1bcece53b..69389a8662 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -4019,7 +4019,7 @@ static void rdma_accept_incoming_migration(void *opaque)
}
rdma->migration_started_on_destination = 1;
- migration_fd_process_incoming(f);
+ migration_fd_process_incoming(f, errp);
}
void rdma_start_incoming_migration(const char *host_port, Error **errp)
--
2.21.0
- [Qemu-devel] [PATCH v4 0/6] Multifd compression support, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 2/6] migration: Make multifd_save_setup() get an Error parameter, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 1/6] migration-test: introduce functions to handle string parameters, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 3/6] migration: Make multifd_load_setup() get an Error parameter,
Juan Quintela <=
- [Qemu-devel] [PATCH v4 5/6] migration: Make no compression operations into its own structure, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 4/6] migration: Add multifd-compress parameter, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 6/6] migration: Add zlib compression multifd support, Juan Quintela, 2019/06/12