[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 21/42] block: Use CAFs for debug breakpoints
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 21/42] block: Use CAFs for debug breakpoints |
Date: |
Fri, 14 Jun 2019 15:28:20 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/14/19 11:12 AM, Max Reitz wrote:
> On 14.06.19 17:29, Vladimir Sementsov-Ogievskiy wrote:
>> 13.06.2019 1:09, Max Reitz wrote:
>>> When looking for a blkdebug node (which implements debug breakpoints),
>>> use bdrv_primary_bs() to iterate through the graph, because that is
>>> where a blkdebug node would be.
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>>
>> Honestly, don't know why blkdebug is always searched in ->file sequence,
>
> Usually, blkdebug is just above the protocol node. So
>
> $format --file--> $protocol
>
> becomes
>
> $format --file--> blkdebug --file--> $protocol
>
> This is why the existing code generally looks for blkdebug under the
> ->file link.
blkdebug is an interesting beast; there are use cases for both:
blkdebug -> qcow2 -> file
for debugging only guest-visible actions, and
qcow2 -> blkdebug -> file
for debugging specific qcow2 metadata actions.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 23/42] blockdev: Use CAF in external_snapshot_prepare(), Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 22/42] block: Use CAFs in bdrv_get_allocated_file_size(), Max Reitz, 2019/06/12