[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_n
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_name |
Date: |
Sun, 16 Jun 2019 20:33:44 +0200 |
On Sun, 16 Jun 2019 23:28:17 +0900
Yoshinori Sato <address@hidden> wrote:
> Signed-off-by: Yoshinori Sato <address@hidden>
THere is no point in sending it as separate patch,
If you'd merged this patch into 3/24 I'd ack it.
So pls merge it there.
> ---
> target/rx/cpu.c | 20 +++-----------------
> 1 file changed, 3 insertions(+), 17 deletions(-)
>
> diff --git a/target/rx/cpu.c b/target/rx/cpu.c
> index a6dde613ab..e3d76af55d 100644
> --- a/target/rx/cpu.c
> +++ b/target/rx/cpu.c
> @@ -72,9 +72,8 @@ static void rx_cpu_reset(CPUState *s)
> static void rx_cpu_list_entry(gpointer data, gpointer user_data)
> {
> const char *typename = object_class_get_name(OBJECT_CLASS(data));
> - int len = strlen(typename) - strlen(RX_CPU_TYPE_SUFFIX);
>
> - qemu_printf("%.*s\n", len, typename);
> + qemu_printf("%s\n", typename);
> }
>
> void rx_cpu_list(void)
> @@ -88,25 +87,12 @@ void rx_cpu_list(void)
> static ObjectClass *rx_cpu_class_by_name(const char *cpu_model)
> {
> ObjectClass *oc;
> - char *typename;
>
> oc = object_class_by_name(cpu_model);
> - if (oc != NULL && object_class_dynamic_cast(oc, TYPE_RX_CPU) != NULL &&
> - !object_class_is_abstract(oc)) {
> - return oc;
> - }
> -
> - typename = g_strdup_printf(RX_CPU_TYPE_NAME("%s"), cpu_model);
> - oc = object_class_by_name(typename);
> - if (oc != NULL && object_class_is_abstract(oc)) {
> + if (object_class_dynamic_cast(oc, TYPE_RX_CPU) == NULL ||
> + object_class_is_abstract(oc)) {
> oc = NULL;
> }
> - g_free(typename);
> -
> - if (!oc) {
> - /* default to rx62n */
> - oc = object_class_by_name(TYPE_RX62N_CPU);
> - }
>
> return oc;
> }
- [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 08/24] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 10/24] target/rx: Emit all disassembly in one prt(), Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 12/24] target/rx: Dump bytes for each insn during disassembly, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 09/24] target/rx: Use prt_ldmi for XCHG_mr disassembly, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 14/24] hw/timer: RX62N internal timer modules, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 07/24] target/rx: Disassemble rx_index_addr into a string, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 04/24] target/rx: Follow the change of tcg., Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 15/24] hw/char: RX62N serial communication interface (SCI), Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_name, Yoshinori Sato, 2019/06/16
- Re: [Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_name,
Igor Mammedov <=
- [Qemu-devel] [PATCH v20 17/24] target/rx: Move rx_load_image to rx-virt., Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 18/24] hw/rx: Honor -accel qtest, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 24/24] BootLinuxConsoleTest: Test the RX-Virt machine, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 01/24] target/rx: TCG translation, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 20/24] qemu/bitops.h: Add extract8 and extract16, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 16/24] hw/rx: RX Target hardware definition, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 03/24] target/rx: CPU definition, Yoshinori Sato, 2019/06/16
- [Qemu-devel] [PATCH v20 19/24] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core, Yoshinori Sato, 2019/06/16