Re: [Qemu-devel] [PATCH] helpers: build vhost-user-gpu only for softmmu

[Marc-André Lureau]

On Fri, Jun 14, 2019 at 8:46 PM Laurent Vivier <address@hidden> wrote:
>
> with
>
>   ./configure --enable-user --disable-tools --disable-system
>
> it fails with:
>
>   /usr/bin/ld: contrib/vhost-user-gpu/main.o: in function 
> `vg_resource_destroy':
>   .../contrib/vhost-user-gpu/main.c:382: undefined reference to 
> `pixman_image_unref'
>   /usr/bin/ld: contrib/vhost-user-gpu/main.o: in function `vg_resource_flush':
>   .../contrib/vhost-user-gpu/main.c:694: undefined reference to 
> `pixman_region_init_rect'
>   /usr/bin/ld: .../contrib/vhost-user-gpu/main.c:763: undefined reference to 
> `pixman_region_fini'
>
> Fixes: d52c454aadcd ("contrib: add vhost-user-gpu")
> Cc: address@hidden
> Signed-off-by: Laurent Vivier <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 8e2fc6624c31..49ddec1dcf35 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -322,11 +322,13 @@ HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) 
> = qemu-bridge-helper$(EXE
>  ifdef CONFIG_LINUX
>  ifdef CONFIG_VIRGL
>  ifdef CONFIG_GBM
> +ifdef CONFIG_SOFTMMU
>  HELPERS-y += vhost-user-gpu$(EXESUF)
>  vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
>  endif
>  endif
>  endif
> +endif
>
>  ifdef BUILD_DOCS
>  DOCS=qemu-doc.html qemu-doc.txt qemu.1 qemu-img.1 qemu-nbd.8 qemu-ga.8
> --
> 2.21.0
>
>


-- 
Marc-André Lureau