Re: [Qemu-devel] [PATCH v3 23/50] cpu: hook plugin vcpu events

[Richard Henderson]

On 6/14/19 10:11 AM, Alex Bennée wrote:
>  static void qemu_wait_io_event(CPUState *cpu)
>  {
> +    bool slept = false;
> +
>      while (cpu_thread_is_idle(cpu)) {
> +        if (!slept) {
> +            slept = true;
> +            qemu_plugin_vcpu_idle_cb(cpu);
> +        }
>          qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
>      }
> +    if (slept) {
> +        qemu_plugin_vcpu_resume_cb(cpu);
> +    }

Maybe better without the variable.

        if (cpu_thread_is_idle(cpu)) {
            qemu_plugin_vcpu_idle_cb(cpu);
            do {
                qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
            } while (cpu_thread_is_idle(cpu);
            qemu_plugin_vcpu_resume_cb(cpu);
        }

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~