[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU PATCH v3 6/9] vmstate: Add support for kernel int
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [QEMU PATCH v3 6/9] vmstate: Add support for kernel integer types |
Date: |
Tue, 18 Jun 2019 16:42:19 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Liran Alon (address@hidden) wrote:
>
>
> > On 18 Jun 2019, at 11:55, Dr. David Alan Gilbert <address@hidden> wrote:
> >
> > * Liran Alon (address@hidden) wrote:
> >> Reviewed-by: Nikita Leshenko <address@hidden>
> >> Reviewed-by: Maran Wilson <address@hidden>
> >> Signed-off-by: Liran Alon <address@hidden>
> >> ---
> >> include/migration/vmstate.h | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> >> index 9224370ed59a..a85424fb0483 100644
> >> --- a/include/migration/vmstate.h
> >> +++ b/include/migration/vmstate.h
> >> @@ -797,6 +797,15 @@ extern const VMStateInfo vmstate_info_qtailq;
> >> #define VMSTATE_UINT64_V(_f, _s, _v) \
> >> VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint64, uint64_t)
> >
> > A comment here stating they're for Linux kernel types would be nice.
>
> I didn’t want to state this because in theory these types can be used not in
> kernel context…
> I thought commit message is sufficient. I think comments in code should be
> made to clarify
> things. But to justify existence I think commit message should be used.
> But if you insist, I have no strong objection of adding such comment.
It's only a 'would be nice' - it's just I don't want people trying to
use them for other places (I'm not sure what happens if you pass a
uint8_t to VMSTATE_U8 ???
> >
> >> +#define VMSTATE_U8_V(_f, _s, _v) \
> >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint8, __u8)
> >> +#define VMSTATE_U16_V(_f, _s, _v) \
> >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint16, __u16)
> >> +#define VMSTATE_U32_V(_f, _s, _v) \
> >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint32, __u32)
> >> +#define VMSTATE_U64_V(_f, _s, _v) \
> >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint64, __u64)
> >> +
> >
> > Have you checked that builds OK on a non-Linux system?
>
> Hmm that’s a good point. No. :P
Worth a check if you can find one lying around :-)
Dave
> -Liran
>
> >
> > Dave
> >
> >> #define VMSTATE_BOOL(_f, _s) \
> >> VMSTATE_BOOL_V(_f, _s, 0)
> >>
> >> @@ -818,6 +827,15 @@ extern const VMStateInfo vmstate_info_qtailq;
> >> #define VMSTATE_UINT64(_f, _s) \
> >> VMSTATE_UINT64_V(_f, _s, 0)
> >>
> >> +#define VMSTATE_U8(_f, _s) \
> >> + VMSTATE_U8_V(_f, _s, 0)
> >> +#define VMSTATE_U16(_f, _s) \
> >> + VMSTATE_U16_V(_f, _s, 0)
> >> +#define VMSTATE_U32(_f, _s) \
> >> + VMSTATE_U32_V(_f, _s, 0)
> >> +#define VMSTATE_U64(_f, _s) \
> >> + VMSTATE_U64_V(_f, _s, 0)
> >> +
> >> #define VMSTATE_UINT8_EQUAL(_f, _s, _err_hint) \
> >> VMSTATE_SINGLE_FULL(_f, _s, 0, 0, \
> >> vmstate_info_uint8_equal, uint8_t, _err_hint)
> >> --
> >> 2.20.1
> >>
> > --
> > Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [QEMU PATCH v3 2/9] KVM: i386: Use symbolic constant for #DB/#BP exception constants, (continued)
- [Qemu-devel] [QEMU PATCH v3 2/9] KVM: i386: Use symbolic constant for #DB/#BP exception constants, Liran Alon, 2019/06/17
- [Qemu-devel] [QEMU PATCH v3 4/9] KVM: i386: Block migration for vCPUs exposed with nested virtualization, Liran Alon, 2019/06/17
- [Qemu-devel] [QEMU PATCH v3 3/9] KVM: i386: Re-inject #DB to guest with updated DR6, Liran Alon, 2019/06/17
- [Qemu-devel] [QEMU PATCH v3 5/9] linux-headers: i386: Modify struct kvm_nested_state to have explicit fields for data, Liran Alon, 2019/06/17
- [Qemu-devel] [QEMU PATCH v3 6/9] vmstate: Add support for kernel integer types, Liran Alon, 2019/06/17
[Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state, Liran Alon, 2019/06/17
Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state, Maran Wilson, 2019/06/18
[Qemu-devel] [QEMU PATCH v3 9/9] KVM: i386: Remove VMX migration blocker, Liran Alon, 2019/06/17